Skip to content

Fix conan build failures #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Fix conan build failures #379

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
841bc85
remove mention of abseil from conanfile
lia-viam Mar 10, 2025
29166ac
Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk into fix/…
lia-viam Mar 10, 2025
5916479
Merge branch 'main' into fix/conan
lia-viam Mar 11, 2025
78b0187
Merge branch 'main' into fix/conan
lia-viam Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def configure(self):
# From some experiments it seems that the shared-ness of these packages
# should match that of the SDK recipe. Failure to do so can cause linker
# errors while compiling, or static initialization errors at runtime for modules.
for lib in ["grpc", "protobuf", "abseil"]:
for lib in ["grpc", "protobuf"]:
self.options[lib].shared = True

def requirements(self):
Expand All @@ -51,7 +51,6 @@ def requirements(self):
self.requires('protobuf/[>=3.17.1]')

self.requires('xtensor/[>=0.24.3]')
self.requires('abseil/[>=20230125.3]')

def build_requirements(self):
if self.options.offline_proto_generation:
Expand Down Expand Up @@ -94,8 +93,6 @@ def package_info(self):
if self.settings.os in ["Linux", "FreeBSD"]:
self.cpp_info.components[component].system_libs = ["pthread"]

self.cpp_info.components["viamapi"].requires.append("abseil::absl_strings")

if self.settings.os in ["Linux", "FreeBSD"]:
self.cpp_info.components["viamsdk"].system_libs.extend(["dl", "rt"])

Expand Down
Loading