Skip to content

Conversation

@lia-viam
Copy link
Collaborator

@lia-viam lia-viam commented Apr 9, 2025

@lia-viam lia-viam requested a review from a team as a code owner April 9, 2025 15:30
@lia-viam lia-viam requested review from njooma and stuqdog and removed request for a team April 9, 2025 15:30
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstractly this looks reasonable to me but tests are failing, so 😢

please re-request review when tests pass and I can look again/approve!

@lia-viam
Copy link
Collaborator Author

@stuqdog thanks for taking a look! i am going to close this one, it seems for now that we might be screwed because i don't know if it's possible to override versions of a build dependency for another target. just waiting on developments in the conan ticket for now

@lia-viam lia-viam closed this Apr 14, 2025
@atlassian
Copy link

atlassian bot commented Sep 22, 2025

🔗 Link your GitHub account to Atlassian

To enable Code Reviewer, please link your GitHub account to your Atlassian account.

Click here to connect your accounts

This is a one-time setup that takes less than a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants