Skip to content

Conversation

@lia-viam
Copy link
Collaborator

@lia-viam lia-viam commented Apr 9, 2025

No description provided.

@lia-viam lia-viam requested a review from a team as a code owner April 9, 2025 16:06
@lia-viam lia-viam requested review from njooma and stuqdog and removed request for a team April 9, 2025 16:06
@acmorrow
Copy link
Member

acmorrow commented Apr 9, 2025

@lia-viam - Looks like something doesn't like that release tag format.

@acmorrow
Copy link
Member

Let's not move forward with this since CMake seems unable to handle rc versions (what?). Anyway, I'll find another way to do testing without this.

@lia-viam
Copy link
Collaborator Author

@acmorrow did some digging and it seems like all the components must be nonnegative integers, see https://cmake.org/cmake/help/latest/command/project.html

i wouldn't be opposed to using the [tweak] to do this, eg 0.8.0.1 or something

@acmorrow
Copy link
Member

Let's just get #410 merged and call it 0.8.0. Meanwhile, could you possibly also take a quick look at viam-modules/mlmodel-tflite#25, which is the same thing? I can't seem to add you as a reviewer - maybe you aren't part of that org?

Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acmorrow acmorrow merged commit f964f9c into main Apr 10, 2025
4 checks passed
@lia-viam lia-viam deleted the lia-viam-patch-4 branch April 10, 2025 19:47
@atlassian
Copy link

atlassian bot commented Sep 22, 2025

🔗 Link your GitHub account to Atlassian

To enable Code Reviewer, please link your GitHub account to your Atlassian account.

Click here to connect your accounts

This is a one-time setup that takes less than a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants