RSDK-8424 - respect ctx deadline when adding module resources #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
lia-viam and
njooma
and removed request for
a team
lia-viam
approved these changes
Apr 23, 2025
src/viam/sdk/rpc/server.hpp
Outdated
| /// @throws `Exception` if a matching `ResourceServer` doesn't exist in the server. | ||
| /// @throws `Exception` if the deadline is not nil and has passed | ||
| void add_resource(std::shared_ptr<Resource> resource, | ||
| std::chrono::system_clock::time_point* deadline); |
Collaborator
There was a problem hiding this comment.
minor but i would favor making this a boost::optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modeled after viamrobotics/viam-python-sdk#904, tested similarly with a modified timeout in simple module.