Skip to content

Conversation

@stuqdog
Copy link
Member

@stuqdog stuqdog commented Jul 25, 2025

Untested here but the job is failing already and this seems to have fixed the docker image so, worth trying!

Untested here but the job is failing already and this seems to have fixed the docker image so, worth trying!
@stuqdog stuqdog requested a review from a team as a code owner July 25, 2025 15:31
@stuqdog stuqdog requested review from lia-viam and njooma and removed request for a team July 25, 2025 15:31
Copy link
Collaborator

@lia-viam lia-viam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, i think since you've branched off the original repo instead of your fork it should be possible to manually run the update protos workflow pointing it to this yml?

@stuqdog
Copy link
Member Author

stuqdog commented Jul 25, 2025

this LGTM, i think since you've branched off the original repo instead of your fork it should be possible to manually run the update protos workflow pointing it to this yml?

Unfortunately that doesn't work so well, the job requires a setting of version variables that comes from the API repo update. If we manually run it, we aren't setting those values and so the update doesn't set them properly.

However, if we rebase the update_protos PR once this is merged, we should get the job to rerun with the update. Just kidding! Since the job failed there's no actual PR open to rebase. So I think we just gotta wait for the next update.

@stuqdog stuqdog merged commit eef814d into main Jul 25, 2025
5 checks passed
@lia-viam lia-viam mentioned this pull request Jul 29, 2025
@atlassian
Copy link

atlassian bot commented Sep 22, 2025

🔗 Link your GitHub account to Atlassian

To enable Code Reviewer, please link your GitHub account to your Atlassian account.

Click here to connect your accounts

This is a one-time setup that takes less than a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants