Skip to content

RSDK-12350 - remove location secret connection code #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
Merged

RSDK-12350 - remove location secret connection code #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a4d479
remove location secret connection code
stuqdog Oct 20, 2025
cc1f0c3
Merge branch 'main' into RSDK-11888-remove-location-secret-connection…
stuqdog Oct 21, 2025
6e1b40f
Merge branch 'main' into RSDK-11888-remove-location-secret-connection…
lia-viam Oct 22, 2025
95b2eb3
Merge branch 'main' into RSDK-11888-remove-location-secret-connection…
stuqdog Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/viam/examples/modules/complex/proto/buf.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ deps:
- remote: buf.build
owner: googleapis
repository: googleapis
commit: 61b203b9a9164be9a834f58c37be6f62
digest: shake256:e619113001d6e284ee8a92b1561e5d4ea89a47b28bf0410815cb2fa23914df8be9f1a6a98dcf069f5bc2d829a2cfb1ac614863be45cd4f8a5ad8606c5f200224
commit: 72c8614f3bd0466ea67931ef2c43d608
digest: shake256:b3ac4d383db09f92ab0ca85d12bff8c49eddf7031bd3a854c260b6ac4ed6a2bb85b52b3393c316d28f8038bf3b8e70cb3d16470e8cc4423007678fb6d89d36d4
3 changes: 0 additions & 3 deletions src/viam/sdk/rpc/dial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,6 @@ const boost::optional<DialOptions>& Options::dial_options() const {
return dial_options_;
}

Credentials::Credentials(std::string payload)
: type_("robot-location-secret"), payload_(std::move(payload)) {}

Credentials::Credentials(std::string type, std::string payload)
: type_(std::move(type)), payload_(std::move(payload)) {}

Expand Down
2 changes: 0 additions & 2 deletions src/viam/sdk/rpc/dial.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ class ViamChannel {

class Credentials {
public:
/// @deprecated use `Credentials(std::string type, std::string payload)`
Credentials(std::string payload);
Credentials(std::string type, std::string payload);
const std::string& type() const;
const std::string& payload() const;
Expand Down