RSDK-12151 Audio Out Component Type #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviamiller
commented
Oct 22, 2025
| /// raw PCM data, pass nullptr if not needed. | ||
| /// @param extra Any additional arguments to the method | ||
| virtual void play(std::vector<uint8_t> const& audio_data, | ||
| std::shared_ptr<audio_info> info, |
Member
Author
There was a problem hiding this comment.
made info a shared pointer so it could be optional by passing a nullptr, unsure if thats the best way to handle
Collaborator
There was a problem hiding this comment.
let's use boost::optional for this sort of thing
oliviamiller
requested review from
lia-viam,
njooma and
stuqdog
and removed request for
a team
lia-viam
requested changes
Oct 23, 2025
Collaborator
lia-viam
left a comment
lia-viam
left a comment
There was a problem hiding this comment.
thanks for the PR again, this is pretty close to mergeable
| /// raw PCM data, pass nullptr if not needed. | ||
| /// @param extra Any additional arguments to the method | ||
| virtual void play(std::vector<uint8_t> const& audio_data, | ||
| std::shared_ptr<audio_info> info, |
Collaborator
There was a problem hiding this comment.
let's use boost::optional for this sort of thing
lia-viam
approved these changes
Oct 23, 2025
Collaborator
lia-viam
left a comment
lia-viam
left a comment
There was a problem hiding this comment.
lgtm, feel free to merge after resolving the conflicts from the overlap with your AudioIn merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio out component type, tested manually using a modifed simple module example.