Skip to content

RSDK-9622 FIX: fix discoverResources input parameters #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martha-johnston merged 1 commit into from
Jan 30, 2025
Merged

RSDK-9622 FIX: fix discoverResources input parameters #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/src/services/discovery.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import 'package:grpc/grpc_connection_interface.dart';

import '../../protos/common/common.dart';
import '../gen/common/v1/common.pb.dart';
import '../../protos/service/discovery.dart';
import '../gen/service/discovery/v1/discovery.pbgrpc.dart';
import '../gen/app/v1/robot.pb.dart';
import '../gen/common/v1/common.pb.dart';
import '../gen/service/discovery/v1/discovery.pbgrpc.dart';
import '../resource/base.dart';
import '../robot/client.dart';
import '../utils.dart';
Expand All @@ -30,7 +30,7 @@ class DiscoveryClient extends Resource implements ResourceRPCClient {
/// // Example:
/// var resources = await myDiscoveryService.discoverResources('myWebcam');
/// ```
Future<List<ComponentConfig>> discoverResources(String discoveryName, {Map<String, dynamic>? extra}) async {
Future<List<ComponentConfig>> discoverResources({Map<String, dynamic>? extra}) async {
final request = DiscoverResourcesRequest(name: name, extra: extra?.toStruct());
final response = await client.discoverResources(request);
return response.discoveries;
Expand Down
6 changes: 2 additions & 4 deletions test/unit_test/services/discovery_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import 'package:fixnum/fixnum.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mockito/mockito.dart';
import 'package:viam_sdk/protos/service/discovery.dart';
import 'package:viam_sdk/src/gen/common/v1/common.pb.dart';
import 'package:viam_sdk/src/gen/app/v1/robot.pb.dart';
import 'package:viam_sdk/src/gen/service/discovery/v1/discovery.pbgrpc.dart';
import 'package:viam_sdk/viam_sdk.dart';
import 'package:viam_sdk/src/gen/app/v1/robot.pb.dart';

import '../mocks/mock_response_future.dart';
import '../mocks/service_clients_mocks.mocks.dart';
Expand Down Expand Up @@ -33,7 +31,7 @@ void main() {
final expected = [ComponentConfig()];
when(serviceClient.discoverResources(any))
.thenAnswer((_) => MockResponseFuture.value(DiscoverResourcesResponse(discoveries: expected)));
final response = await client.discoverResources('discoveryName');
final response = await client.discoverResources();
expect(response, equals(expected));
});
});
Expand Down