RSDK-13626: Remove getImage and renderFrame from camera service#513
Open
RSDK-13626: Remove getImage and renderFrame from camera service#513
Conversation
Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs from camera.proto. Both were already throwing UnimplementedError. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
allisonschiang
requested changes
Mar 19, 2026
Member
allisonschiang
left a comment
allisonschiang
left a comment
There was a problem hiding this comment.
a test is failing:
Dart analysis fails with:
lib/src/components/camera/service.dart:12:7 - Missing concrete implementations of 'CameraServiceBase.getImage' and 'CameraServiceBase.renderFrame'. ... - non_abstract_class_inherits_abstract_member
allisonschiang
approved these changes
Mar 19, 2026
Member
allisonschiang
left a comment
allisonschiang
left a comment
There was a problem hiding this comment.
oops after leaving that comment I realized its failing because its waiting for the api changes....
Member
Author
nw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getImageandrenderFrameoverride methods fromCameraServicehttpbody.pb.dartimportPre-emptive cleanup ahead of viamrobotics/api#758 which deletes these RPCs from
camera.proto. Both methods were already throwingUnimplementedError. Without this change, the@overrideannotations will cause compilation failures when the parent class no longer declares these methods after proto regeneration.Test plan
🤖 Generated with Claude Code