Skip to content

Commit 83b5622

Browse files
Merge pull request #39 from viamrobotics/stream-fix
Ensure consistent streamClient and resourceName in stream related effects
2 parents d80b684 + da509ec commit 83b5622

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.changeset/whole-snakes-grin.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@viamrobotics/svelte-sdk': patch
3+
---
4+
5+
Ensure consistent streamClient and resourceName in stream related effects

src/lib/hooks/create-stream-client.svelte.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,16 @@ export const createStreamClient = (
3030
};
3131

3232
$effect(() => {
33-
streamClient?.on('track', handleTrack);
34-
return () => streamClient?.off('track', handleTrack);
33+
const client = streamClient;
34+
client?.on('track', handleTrack);
35+
return () => client?.off('track', handleTrack);
3536
});
3637

3738
$effect(() => {
38-
streamClient?.getStream(resourceName());
39-
return () => streamClient?.remove(resourceName());
39+
const name = resourceName();
40+
const client = streamClient;
41+
client?.getStream(name);
42+
return () => client?.remove(name);
4043
});
4144

4245
const queryOptions = $derived(

0 commit comments

Comments
 (0)