Skip to content

Prevent streams from throwing timeout errors #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Prevent streams from throwing timeout errors #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd291e2
init
micheal-parks Jun 20, 2025
87c666d
Merge branch 'main' into stream-fix-1
micheal-parks Jun 20, 2025
26e65c1
better stream handling
micheal-parks Jun 20, 2025
b2c1a5f
cleanup
micheal-parks Jun 20, 2025
b9c6c09
changeset
micheal-parks Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaky-fans-enjoy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@viamrobotics/svelte-sdk': patch
---

Don't throw errors in createStreamClient hook from stream timeouts
14 changes: 11 additions & 3 deletions src/lib/hooks/create-stream-client.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const createStreamClient = (
);

const handleTrack = (event: unknown) => {
const [stream] = (event as { streams: MediaStream[] }).streams;
const [stream] = (event as RTCTrackEvent).streams;

if (!stream || stream.id !== resourceName()) {
return;
Expand All @@ -35,8 +35,9 @@ export const createStreamClient = (
});

$effect(() => {
streamClient?.getStream(resourceName());
return () => streamClient?.remove(resourceName());
const name = resourceName();
streamClient?.add(name);
return () => streamClient?.remove(name);
});

const queryOptions = $derived(
Expand All @@ -52,7 +53,14 @@ export const createStreamClient = (
],
enabled: streamClient !== undefined,
retry: false,

/**
* Resolution options are fairly static,
* so we don't refetch often.
*/
refetchOnWindowFocus: false,
refetchOnMount: false,

queryFn: async () => {
return streamClient?.getOptions(resourceName());
},
Expand Down
Loading