Skip to content

Add nodejs example #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2024
Merged

Add nodejs example #377

merged 4 commits into from
Oct 8, 2024

Conversation

@edaniels
Copy link
Contributor

@edaniels edaniels commented Oct 7, 2024 •
edited
Loading

@edaniels edaniels requested a review from a team as a code owner October 7, 2024 19:42
@edaniels
Copy link
Contributor Author

edaniels commented Oct 7, 2024

@njooma lmk if this is sufficient for the "node SDK"

njooma
njooma requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to how we have detailed instructions for react-native, can you add any additional dependencies/steps one would need to do to get node to work? E.g. updating the global transport, needing the data channel library, etc.

@edaniels
Copy link
Contributor Author

edaniels commented Oct 8, 2024

Similar to how we have detailed instructions for react-native, can you add any additional dependencies/steps one would need to do to get node to work? E.g. updating the global transport, needing the data channel library, etc.

Yep on it

@edaniels edaniels requested a review from njooma October 8, 2024 17:12
@edaniels
Copy link
Contributor Author

edaniels commented Oct 8, 2024

Similar to how we have detailed instructions for react-native, can you add any additional dependencies/steps one would need to do to get node to work? E.g. updating the global transport, needing the data channel library, etc.

Yep on it

@njooma done

njooma
njooma approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved % one change

examples/node/README.md Outdated

#### `main.ts`

The `App.tsx` file was updated to include the following polyfills and updates:
Copy link
Member

@njooma njooma Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `App.tsx` file was updated to include the following polyfills and updates:
The `main.ts` file was updated to include the following polyfills and updates:

Copy link
Contributor Author

@edaniels edaniels Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you caught me!

@edaniels edaniels merged commit 5c58da6 into viamrobotics:main Oct 8, 2024
3 checks passed
@edaniels edaniels deleted the node branch October 8, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njooma njooma njooma approved these changes

@stuqdog stuqdog Awaiting requested review from stuqdog stuqdog is a code owner automatically assigned from viamrobotics/sdk-netcode

@purplenicole730 purplenicole730 Awaiting requested review from purplenicole730 purplenicole730 is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edaniels @njooma