emit disconnected event and throw on dial error #675
Merged
+387
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-transport-and-signaling-client-for-dialing-webrtc
This reverts commit 8c20e5b.
…' into dont-swallow-errors-when-dialing
…' into dont-swallow-errors-when-dialing
DTCurrie
requested review from
lia-viam and
njooma
and removed request for
a team
njooma
approved these changes
Nov 13, 2025
…to reuse-transport-and-signaling-client-for-dialing-webrtc
…to dont-swallow-errors-when-dialing
…' into dont-swallow-errors-when-dialing
Base automatically changed from
reuse-transport-and-signaling-client-for-dialing-webrtc
to
main
November 17, 2025 21:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the
RobotClient.dialmethod silently swallowed connection errors, making it impossible for developers to detect or handle connection failures.Previously, if both WebRTC and subsequent gRPC connection attempts failed, the dial method would catch the exceptions, log them to the console, and return
thisas if the connection were successful.The method now properly handles connection failures in two ways. For each failed connection attempt (WebRTC or gRPC), a
DISCONNECTEDevent is emitted with the specific error, allowing developers to observe failures through the event system. When both WebRTC and gRPC connection methods fail, the method throws anErrorwith the message "Failed to connect via all methods". The thrown error includes both original errors in itscauseproperty as an array, providing full context about why the connection failed.