Skip to content

Add a simple doc on the convex poly constraints. #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2024
Merged

Add a simple doc on the convex poly constraints. #264

merged 4 commits into from
Nov 9, 2024

Conversation

@VeriTas-arch
Copy link
Contributor

@VeriTas-arch VeriTas-arch commented Nov 7, 2024

Contents

VeriTas-arch
VeriTas-arch commented Nov 8, 2024
View reviewed changes
Copy link
Contributor Author

@VeriTas-arch VeriTas-arch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of them are minor changes.

viblo
viblo requested changes Nov 9, 2024
View reviewed changes
Copy link
Owner

@viblo viblo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment

VeriTas-arch
VeriTas-arch commented Nov 9, 2024
View reviewed changes
Copy link
Contributor Author

@VeriTas-arch VeriTas-arch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Adding is the correct way here. This is what the user would need pass in to this method, not what the method does.

Well, it is in deed an omission, which is fixed already.

@VeriTas-arch VeriTas-arch requested a review from viblo November 9, 2024 12:21
@viblo viblo merged commit e921f53 into viblo:master Nov 9, 2024
5 checks passed
@viblo
Copy link
Owner

viblo commented Nov 9, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viblo viblo viblo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VeriTas-arch @viblo