Add example of applying same aspect on linux and darwin #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a concrete example showing how to apply the same aspect across Linux (NixOS) and macOS, and slightly clarifies prior wording.
- Clarifies sentence about where aspects are applied.
- Adds a Nix code example demonstrating cross-OS reuse of the scrolling-desktop aspect.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| instead of where they are applied. | ||
| instead of where they are specifically applied. | ||
|
|
||
| In the following example, the `scrolling-desktop` aspect is included accross different operating systems: |
There was a problem hiding this comment.
Corrected spelling of 'accross' to 'across'.
Suggested change
| In the following example, the `scrolling-desktop` aspect is included accross different operating systems: | |
| In the following example, the `scrolling-desktop` aspect is included across different operating systems: |
| instead of where they are specifically applied. | ||
|
|
||
| In the following example, the `scrolling-desktop` aspect is included accross different operating systems: | ||
| On Linux, `flake.modules.nixos.scrolling-destop` might enable [`niri`](https://variety4me.github.io/niri_docs/) and on MacOS, `flake.modules.darwin.scrolling-desktop` might enable [`PaperWM.spoon`](https://github.com/mogenson/PaperWM.spoon). |
There was a problem hiding this comment.
Corrected spelling of 'scrolling-destop' to 'scrolling-desktop'.
Suggested change
| On Linux, `flake.modules.nixos.scrolling-destop` might enable [`niri`](https://variety4me.github.io/niri_docs/) and on MacOS, `flake.modules.darwin.scrolling-desktop` might enable [`PaperWM.spoon`](https://github.com/mogenson/PaperWM.spoon). | |
| On Linux, `flake.modules.nixos.scrolling-desktop` might enable [`niri`](https://variety4me.github.io/niri_docs/) and on MacOS, `flake.modules.darwin.scrolling-desktop` might enable [`PaperWM.spoon`](https://github.com/mogenson/PaperWM.spoon). |
| instead of where they are specifically applied. | ||
|
|
||
| In the following example, the `scrolling-desktop` aspect is included accross different operating systems: | ||
| On Linux, `flake.modules.nixos.scrolling-destop` might enable [`niri`](https://variety4me.github.io/niri_docs/) and on MacOS, `flake.modules.darwin.scrolling-desktop` might enable [`PaperWM.spoon`](https://github.com/mogenson/PaperWM.spoon). |
There was a problem hiding this comment.
Use Apple's correct casing: 'macOS' instead of 'MacOS'.
Suggested change
| On Linux, `flake.modules.nixos.scrolling-destop` might enable [`niri`](https://variety4me.github.io/niri_docs/) and on MacOS, `flake.modules.darwin.scrolling-desktop` might enable [`PaperWM.spoon`](https://github.com/mogenson/PaperWM.spoon). | |
| On Linux, `flake.modules.nixos.scrolling-destop` might enable [`niri`](https://variety4me.github.io/niri_docs/) and on macOS, `flake.modules.darwin.scrolling-desktop` might enable [`PaperWM.spoon`](https://github.com/mogenson/PaperWM.spoon). |
| { inputs, ... }: | ||
| { | ||
| flake.nixosConfigurations.my-host = inputs.nixpkgs.lib.nixosSystem { | ||
| system = "aarm64-linux"; |
There was a problem hiding this comment.
Invalid Nix system identifier; use 'aarch64-linux' instead of 'aarm64-linux'.
Suggested change
| system = "aarm64-linux"; | |
| system = "aarch64-linux"; |
| modules = with inputs.self.modules.nixos; [ ai ssh vpn mac-like-keyboard scrolling-desktop ]; | ||
| }; | ||
| flake.darwinConfigurations.my-host = inputs.nix-darwin.lib.darwinSystem { | ||
| system = "aarm64-darwin"; |
There was a problem hiding this comment.
Invalid Nix system identifier; use 'aarch64-darwin' instead of 'aarm64-darwin'.
Suggested change
| system = "aarm64-darwin"; | |
| system = "aarch64-darwin"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.