Draft
Conversation
|
Props for the http caching headers |
Zankaria
suggested changes
Jun 19, 2025
Zankaria
reviewed
Jun 20, 2025
inc/config.php
Outdated
| // Which board should we serve for ukko | ||
| $config['banner_ukko'] = 'ukko'; | ||
| // Allowed banner extensions | ||
| $config['banner_ext'] = ['jpg', 'jpeg', 'png', 'gif', 'webp']; |
There was a problem hiding this comment.
🤓Actually, it doesn't make much sense to put them here since this is a limit of the software, and i'll argue it doesn't make much sense for somebody to configure this while they could simply only use the banners of the extensions they want
inc/Service/BannersService.php
Outdated
| private function getFilesInDirectory(string $dir): array { | ||
| if (!\is_dir($dir)) { | ||
| $this->logger->log( | ||
| LogDriver::WARNING, |
There was a problem hiding this comment.
🤓☝️
This and the one in serve are errors though
Banners 8chan patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also closes #945