Fix/add chunking #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stormheg
suggested changes
Jul 21, 2025
Member
Stormheg
left a comment
Stormheg
left a comment
There was a problem hiding this comment.
@JochemKuipers can we add tests for this functionality?
Long text should be split up in a predictable number of blocks. I see there is some logic which I suppose is trying to make the split occur at the sentence boundary. We should check this logic works properly with different inputs.
Contributor
|
I've seen some issues with this. As the markup text (ssml) is also split. So a tag like We need to have a look for a more bulletproof solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.