Use linear RGB downscaling for most/some downscaling operations. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awused
force-pushed
the
linear
branch
2 times, most recently
from
565128d to
bc7db1f
Compare
Didn't include nearest_aligned since it shouldn't matter when there's no blending of pixels going on.
Author
|
Since the nearest neighbour implementation is using blending it should also be done in linear RGB, and I was able to replicate the same problems from the bug report. |
awused
commented
Dec 12, 2021
|
|
||
| if (w <= h and w == size) or (h <= w and h == size): | ||
| return img | ||
| img = srgb2linear(img) |
Author
There was a problem hiding this comment.
As far as I can tell this resize() function can be entered both inside of another converted block. It's probably best to just introduce wrapper types to avoid double conversions anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't include nearest_aligned since it shouldn't matter when there's no blending of pixels going on.
This is a pretty minimal, targeted change, and it's also really poorly tested since I've only run it locally myself without testing a wide range of settings or inputs. I am also certainly missing some places where downscaling can happen, but these seem to be the places used during OTF augmentations for my config and I didn't want to make a very invasive change to an unfamiliar Python codebase.
Probably not ready to merge, but probably usable by people who want to apply it locally.