Specify that not entering a time will make date filter NOT work#643
Open
ParkerK wants to merge 1 commit intovictornpb:masterfrom
Open
Specify that not entering a time will make date filter NOT work#643ParkerK wants to merge 1 commit intovictornpb:masterfrom
ParkerK wants to merge 1 commit intovictornpb:masterfrom
Conversation
|
Ahhhh I faced this too (#709). |
|
My bug actually was present after picking a time fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the way
datetime-localworks, the value is null if any of the date/time is not filled out. So if you don't fill out the time, the filter will be ignored. This confused me for a bit, and I assume it is the cause of issue: #591All I did was update the message to specify that all fields must be filled out