UI Controls: Increase the clickable area of buttons#2734
Draft
DanielMcInnes wants to merge 1 commit intomainfrom
Draft
UI Controls: Increase the clickable area of buttons#2734DanielMcInnes wants to merge 1 commit intomainfrom
DanielMcInnes wants to merge 1 commit intomainfrom
Conversation
DanielMcInnes
force-pushed
the
2684-increase-clickable-area-2
branch
2 times, most recently
from
41692b8 to
7e1aaf5
Compare
DanielMcInnes
force-pushed
the
2684-increase-clickable-area-2
branch
2 times, most recently
from
342eb3f to
2aa8d73
Compare
DanielMcInnes
force-pushed
the
2684-increase-clickable-area-2
branch
from
2aa8d73 to
a402117
Compare
chriadam
reviewed
Dec 18, 2025
| property alias expandedClickableArea: expandedClickableArea | ||
| property var expandedSceneCoords | ||
|
|
||
| onXChanged: sceneCoordsTimer.restart() |
Contributor
There was a problem hiding this comment.
I would prefer Qt.callLater(), or even better: automatic binding re-evaluation whenever x/y/width/height change.
chriadam
reviewed
Dec 18, 2025
| onExpandedSceneCoordsChanged: { | ||
| overlappingButtonPairs = overlappingPairs(clickableSiblings) | ||
| } | ||
| onOverlappingButtonPairsChanged: { |
Contributor
There was a problem hiding this comment.
all the logic here needs to move to C++ as it will be recalculated frequently, I assume (any x/y/width/height change, also of siblings)
Contributor
|
This is moving in a very nice direction, and is almost there. But, there's enough complexity here to make me want to move this back to v1.3.0 scope, and do the simpler option for v1.2.0 release (i.e. just increasing the size of the touch area in the switch-related buttons for now, with manually-defined geometry). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2684