Skip to content

Generator: Always show warm-up & cool-down page #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReinvdZee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Generator: Always show warm-up & cool-down page #2762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pages/settings/PageSettingsGenerator.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ Page {
ListNavigation {
//% "Warm-up & cool-down"
text: qsTrId("settings_page_generator_warm_up_cool_down")
preferredVisible: capabilities.value & warmupCapability
onClicked: Global.pageManager.pushPage(warmupPageComponent, { title: text })

Component {
Expand All @@ -56,10 +55,18 @@ Page {
id: settingsListView

model: VisibleItemModel {
PrimaryListLabel {
//% "Warm-up & cool-down is unavailable with the current inverter/charger firmware. \nPlease update to the latest firmware to be able to adjust these settings."
text: qsTrId("page_settings_generator_warm_up_cool_down_unavailable_message")
preferredVisible: !(capabilities.value & warmupCapability)
}

ListSpinBox {
//% "Warm-up time"
text: qsTrId("page_settings_generator_warm_up_time")
dataItem.uid: settingsBindPrefix + "/WarmUpTime"
enabled: capabilities.value & warmupCapability
secondaryText: enabled ? dataItem.value : "--"
suffix: "s"
decimals: 0
stepSize: 10
Expand All @@ -69,6 +76,8 @@ Page {
//% "Cool-down time"
text: qsTrId("page_settings_generator_cool_down_time")
dataItem.uid: settingsBindPrefix + "/CoolDownTime"
enabled: capabilities.value & warmupCapability
secondaryText: enabled ? dataItem.value : "--"
suffix: "s"
decimals: 0
stepSize: 10
Expand All @@ -78,6 +87,8 @@ Page {
//% "Generator stop time"
text: qsTrId("page_settings_generator_stop_time")
dataItem.uid: settingsBindPrefix + "/GeneratorStopTime"
enabled: capabilities.value & warmupCapability
secondaryText: enabled ? dataItem.value : "--"
suffix: "s"
decimals: 0
stepSize: 1
Expand Down