UI Controls: add wifi settings button to status bar#2845
UI Controls: add wifi settings button to status bar#2845ybott-qinetic wants to merge 2 commits intomainfrom
Conversation
| onWifiButtonClicked: { | ||
| Global.pageManager.pushPage("/pages/settings/PageSettingsWifi.qml", | ||
| {"title": qsTrId("pagesettingsconnectivity_wifi")}) | ||
| } |
There was a problem hiding this comment.
The breadcrumbs do not show the "Settings" root element.
There was a problem hiding this comment.
It would be nice to preserve the Settings > Connectivity breadcrumb chain. You could put a couple of functions in SettingsPage.qml and PageSettingsConnectivity.qml to get them to push the appropriate pages, and then you wouldn't need to duplicate the "Wifi" and "Mobile network" translation ids as you could reference the text from the list items directly within those pages.
There was a problem hiding this comment.
The buttons are visible when the Control/Switch panes are open, so currently when those are open, it's possible to click the WiFi/GSM buttons and open the settings pages below.
You'll need something like goToNotificationsPage() in MainView.qml, which pops all pages and closes the card loader before going to the notifications page.
ybott-qinetic
force-pushed
the
ttomkins/add-statusbar-wifi-button
branch
from
b94f1d7 to
9b79e96
Compare
ybott-qinetic
force-pushed
the
ttomkins/add-statusbar-wifi-button
branch
from
9b79e96 to
1026c8b
Compare
|
|
||
| onWifiButtonClicked: { | ||
| Global.pageManager.pushPage("/pages/settings/PageSettingsWifi.qml", | ||
| {"title": qsTrId("pagesettingsconnectivity_wifi")}) |
There was a problem hiding this comment.
For maintenance, move the pagesettingsconnectivity_wifi translation id to CommonWords. Otherwise if the original pagesettingsconnectivity_wifi translation source is removed, it's not obvious that the translation will disappear from as well. Eventually we will probably get rid of CommonWords, but since we're using translation ids, we'll have to do this for now.
There was a problem hiding this comment.
(This comment is irrelevant if you push the pages from the settings pages instead, as per the comments below)
| return "qrc:/images/icon_WiFi_noconnection_32.svg" | ||
| } | ||
| } | ||
| StatusBarButton { |
There was a problem hiding this comment.
When the app is showing one of the main pages, after 6 seconds it goes into "idle" mode where the top buttons fade out. Previously the Wifi and GSM indicators remained visible in this idle mode, but now they fade out of view.
There was a problem hiding this comment.
Also, the wifi icon is now coloured blue, and there's a bit too much space between the icons now:
Before:
After:
| onWifiButtonClicked: { | ||
| Global.pageManager.pushPage("/pages/settings/PageSettingsWifi.qml", | ||
| {"title": qsTrId("pagesettingsconnectivity_wifi")}) | ||
| } |
There was a problem hiding this comment.
It would be nice to preserve the Settings > Connectivity breadcrumb chain. You could put a couple of functions in SettingsPage.qml and PageSettingsConnectivity.qml to get them to push the appropriate pages, and then you wouldn't need to duplicate the "Wifi" and "Mobile network" translation ids as you could reference the text from the list items directly within those pages.
| onWifiButtonClicked: { | ||
| Global.pageManager.pushPage("/pages/settings/PageSettingsWifi.qml", | ||
| {"title": qsTrId("pagesettingsconnectivity_wifi")}) | ||
| } |
There was a problem hiding this comment.
The buttons are visible when the Control/Switch panes are open, so currently when those are open, it's possible to click the WiFi/GSM buttons and open the settings pages below.
You'll need something like goToNotificationsPage() in MainView.qml, which pops all pages and closes the card loader before going to the notifications page.
ybott-qinetic
force-pushed
the
ttomkins/add-statusbar-wifi-button
branch
from
1026c8b to
a2f612b
Compare
2 participants
Contributes to #2834