Open
Conversation
chriadam
reviewed
Mar 6, 2026
| valueText: quantityInfo.number | ||
| unit: Global.systemSettings.toPreferredUnit(ioChannel.unitType) | ||
| unitText: quantityInfo.unit === VenusOS.Units_None ? ioChannel.unitText : quantityInfo.unit | ||
| unitText: quantityInfo.unitType === VenusOS.Units_None ? ioChannel.unitText : quantityInfo.unit |
Contributor
There was a problem hiding this comment.
the last one is also quantityInfo.unit should it also be updated?
Contributor
Author
There was a problem hiding this comment.
No, as quantityInfo.unit is a string, while quantityInfo.unitType is an int.
(Would be nice to rename quantityInfo.unit to quantityInfo.unitText at some point to reduce confusion.)
blammit
force-pushed
the
blam/iochannel-label
branch
from
c0b65e2 to
76e35a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2869
Fixes to show the custom unit, as per here: