Improve playlist alignment when PDT across playlists is inconsistent #7482
+80
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
3 tasks
hongjun-bae
reviewed
Nov 10, 2025
Collaborator
hongjun-bae
left a comment
hongjun-bae
left a comment
There was a problem hiding this comment.
I understand that this modification was made because simply increasing the tolerance cannot fundamentally resolve cases where the PDT alignment is completely incorrect.
|
|
||
| const delta = (targetPDT - refPDT) / 1000 - (frag.start - refFrag.start); | ||
| const dateDifference = (targetPDT - refPDT) / 1000; | ||
| if (Math.abs(dateDifference) > Math.max(60, details.totalduration)) { |
Collaborator
There was a problem hiding this comment.
The issue of small timing gaps, such as 352ms, was raised in #7557, but what was the reason for setting the PDT to 60 seconds? Is there a specific reason why “totalduration” was set as the default value? I’m worried that I’m not allowing for enough discontinuities.
Collaborator
There was a problem hiding this comment.
And if the alignment fails like this, logging will be necessary.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist