Fix PlayReady key endianness #7510

ShubhamSharma2311 · 2025-08-28T21:08:21Z

All unwanted code is removed and the package-lock.json file is also fixed.

robwalch · 2025-08-29T04:51:57Z

Hi @ShubhamSharma2311,

Did you mean to merge these changes into the branch submitted for #7509?

ShubhamSharma2311 · 2025-08-29T06:22:07Z

#7510 (comment)
yes sir

hongfeih-es · 2025-08-29T07:49:03Z

src/controller/eme-controller.ts

      },
    );
+
+    // Handle case where no keys matched but all have the same status


Hey @ShubhamSharma2311 how can we reproduce this? not sure this is required.
Still saw wrong key ids, seems sometimes endianness doesn't need to be changed, is this why?
Correct:

e13d04505bd346a088b41e3b8e9e97af

76becf7d11af43698295422217009743

Incorrect:

50043de1d35ba04688b41e3b8e9e97af

7dcfbe76af1169438295422217009743

[log] > [eme]: unmatched key status change "status-pending" for keyStatuses keyId: e13d04505bd346a088b41e3b8e9e97af session keyId: b255031432584910a8272213421391b8 uri: data:text/plain;charset=UTF-16;base64,BgIAAAEAAQD8ATwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ARgBBAE4AVgBzAGwAZwB5AEUARQBtAG8ASgB5AEkAVABRAGgATwBSAHUAQQA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBVAEMAZwBNADgARQBLADkAeQBsAFEAPQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APAAvAEQAQQBUAEEAPgA8AC8AVwBSAE0ASABFAEEARABFAFIAPgA= eme-controller.ts:915 [log] > [eme]: unmatched key status change "status-pending" for keyStatuses keyId: 76becf7d11af43698295422217009743 session keyId: b255031432584910a8272213421391b8 uri: data:text/plain;charset=UTF-16;base64,BgIAAAEAAQD8ATwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ARgBBAE4AVgBzAGwAZwB5AEUARQBtAG8ASgB5AEkAVABRAGgATwBSAHUAQQA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBVAEMAZwBNADgARQBLADkAeQBsAFEAPQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APAAvAEQAQQBUAEEAPgA8AC8AVwBSAE0ASABFAEEARABFAFIAPgA= eme-controller.ts:915 [log] > [eme]: unmatched key status change "status-pending" for keyStatuses keyId: 50043de1d35ba04688b41e3b8e9e97af session keyId: b255031432584910a8272213421391b8 uri: data:text/plain;charset=UTF-16;base64,BgIAAAEAAQD8ATwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ARgBBAE4AVgBzAGwAZwB5AEUARQBtAG8ASgB5AEkAVABRAGgATwBSAHUAQQA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBVAEMAZwBNADgARQBLADkAeQBsAFEAPQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APAAvAEQAQQBUAEEAPgA8AC8AVwBSAE0ASABFAEEARABFAFIAPgA= eme-controller.ts:915 [log] > [eme]: unmatched key status change "status-pending" for keyStatuses keyId: 7dcfbe76af1169438295422217009743 session keyId: b255031432584910a8272213421391b8 uri: data:text/plain;charset=UTF-16;base64,BgIAAAEAAQD8ATwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ARgBBAE4AVgBzAGwAZwB5AEUARQBtAG8ASgB5AEkAVABRAGgATwBSAHUAQQA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBVAEMAZwBNADgARQBLADkAeQBsAFEAPQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APAAvAEQAQQBUAEEAPgA8AC8AVwBSAE0ASABFAEEARABFAFIAPgA= eme-controller.ts:915 [log] > [eme]: unmatched key status change "usable" for keyStatuses keyId: e13d04505bd346a088b41e3b8e9e97af session keyId: b255031432584910a8272213421391b8 uri: data:text/plain;charset=UTF-16;base64,BgIAAAEAAQD8ATwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ARgBBAE4AVgBzAGwAZwB5AEUARQBtAG8ASgB5AEkAVABRAGgATwBSAHUAQQA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBVAEMAZwBNADgARQBLADkAeQBsAFEAPQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APAAvAEQAQQBUAEEAPgA8AC8AVwBSAE0ASABFAEEARABFAFIAPgA= eme-controller.ts:915 [log] > [eme]: unmatched key status change "usable" for keyStatuses keyId: 76becf7d11af43698295422217009743 session keyId: b255031432584910a8272213421391b8 uri: data:text/plain;charset=UTF-16;base64,BgIAAAEAAQD8ATwAVwBSAE0ASABFAEEARABFAFIAIAB4AG0AbABuAHMAPQAiAGgAdAB0AHAAOgAvAC8AcwBjAGgAZQBtAGEAcwAuAG0AaQBjAHIAbwBzAG8AZgB0AC4AYwBvAG0ALwBEAFIATQAvADIAMAAwADcALwAwADMALwBQAGwAYQB5AFIAZQBhAGQAeQBIAGUAYQBkAGUAcgAiACAAdgBlAHIAcwBpAG8AbgA9ACIANAAuADAALgAwAC4AMAAiAD4APABEAEEAVABBAD4APABQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsARQBZAEwARQBOAD4AMQA2ADwALwBLAEUAWQBMAEUATgA+ADwAQQBMAEcASQBEAD4AQQBFAFMAQwBUAFIAPAAvAEEATABHAEkARAA+ADwALwBQAFIATwBUAEUAQwBUAEkATgBGAE8APgA8AEsASQBEAD4ARgBBAE4AVgBzAGwAZwB5AEUARQBtAG8ASgB5AEkAVABRAGgATwBSAHUAQQA9AD0APAAvAEsASQBEAD4APABDAEgARQBDAEsAUwBVAE0APgBVAEMAZwBNADgARQBLADkAeQBsAFEAPQA8AC8AQwBIAEUAQwBLAFMAVQBNAD4APAAvAEQAQQBUAEEAPgA8AC8AVwBSAE0ASABFAEEARABFAFIAPgA=

It's changed when read from the PlayReady EXT-X-KEY, so it needs to be changes here too to match:

hls.js/src/utils/mediakeys-helper.ts

Lines 181 to 205 in 665ea29

export function parsePlayReadyWRM(keyBytes: Uint8Array<ArrayBuffer>) {

const keyBytesUtf16 = new Uint16Array(

keyBytes.buffer,

keyBytes.byteOffset,

keyBytes.byteLength / 2,

);

const keyByteStr = String.fromCharCode.apply(null, Array.from(keyBytesUtf16));

// Parse Playready WRMHeader XML

const xmlKeyBytes = keyByteStr.substring(

keyByteStr.indexOf('<'),

keyByteStr.length,

);

const parser = new DOMParser();

const xmlDoc = parser.parseFromString(xmlKeyBytes, 'text/xml');

const keyData = xmlDoc.getElementsByTagName('KID')[0];

if (keyData) {

const keyId = keyData.childNodes[0]

? keyData.childNodes[0].nodeValue

: keyData.getAttribute('VALUE');

if (keyId) {

const keyIdArray = base64Decode(keyId).subarray(0, 16);

// KID value in PRO is a base64-encoded little endian GUID interpretation of UUID

// KID value in ‘tenc’ is a big endian UUID GUID interpretation of UUID

changeEndianness(keyIdArray);

@hongfeih-es,

I plan to merge these changes. I have another PR in the works to improve Multi-key handling (group playlist key data with different key-is in the same session). I'll share more soon.

sir, now I have to fix this thing #7510 (comment). am I right ??

sir, now I have to fix this thing #7510 (comment). am I right ??

No. These changes have been merged. New changes are in review with #7517.

Please leave review comments on #7517. This PR can be tested in the branch preview: https://bugfix-eme-multi-key.hls-js-4zn.pages.dev/demo/.

Or, file new issues against latest dev/canary at https://hlsjs-dev.video-dev.org/demo/.

src/controller/eme-controller.ts

(cherry picked from commit f9e23c0)

ShubhamSharma2311 and others added 2 commits August 29, 2025 02:33

remove unecessary lines and fix the package-lock.json file

d46a6df

Merge branch 'master' into fix/playready-key-endianness-clean

90a1552

ShubhamSharma2311 changed the title ~~remove unwanted lines and fix the package-lock.json file~~ fix playready-key-endianness and remove the previous conflicts Aug 29, 2025

hongfeih-es reviewed Aug 29, 2025

View reviewed changes

robwalch linked an issue Aug 29, 2025 that may be closed by this pull request

extract key id incorrectly from key statuses when using PlayReady #7508

Closed

5 tasks

robwalch added this to the 1.7.0 milestone Aug 29, 2025

robwalch added the DRM label Aug 29, 2025

robwalch added this to HLS.js Release Planning and Backlog and EME and Content Protection (DRM) Aug 29, 2025

github-project-automation bot moved this to Top priorities in HLS.js Release Planning and Backlog Aug 29, 2025

robwalch reviewed Aug 29, 2025

View reviewed changes

src/controller/eme-controller.ts Outdated Show resolved Hide resolved

robwalch added 2 commits August 29, 2025 10:45

Update src/controller/eme-controller.ts

ca9f066

Prettier formatting

a9e646e

robwalch approved these changes Aug 29, 2025

View reviewed changes

robwalch changed the title ~~fix playready-key-endianness and remove the previous conflicts~~ Fix PlayReady key endianness Aug 29, 2025

robwalch merged commit f9e23c0 into video-dev:master Aug 29, 2025
12 checks passed

github-project-automation bot moved this to Done in EME and Content Protection (DRM) Aug 29, 2025

robwalch pushed a commit that referenced this pull request Aug 30, 2025

Fix PlayReady key endianness (#7510)

4a334e9

(cherry picked from commit f9e23c0)

robwalch mentioned this pull request Aug 30, 2025

Multi-key handling #7517

Draft

3 tasks

yajin2021 mentioned this pull request Sep 1, 2025

Extract key id incorrectly from key statuses when using PlayReady DiceTechnology/hls.js#115

Merged

This was referenced Sep 2, 2025

Cannot filter the HD stream for Playready DRM in edge #7519

Closed

extract key id incorrectly from key statuses when using PlayReady #7508

Closed

robwalch modified the milestones: 1.7.0, 1.6.12 Sep 4, 2025

This was referenced Sep 4, 2025

Error handling for PlayReady key with no status change #7527

Merged

Merge v1.6.12 changes into development #7529

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix PlayReady key endianness #7510

Fix PlayReady key endianness #7510

Uh oh!

ShubhamSharma2311 commented Aug 28, 2025

Uh oh!

robwalch commented Aug 29, 2025 •

edited

Loading

Uh oh!

ShubhamSharma2311 commented Aug 29, 2025

Uh oh!

hongfeih-es Aug 29, 2025 •

edited

Loading

Uh oh!

robwalch Aug 29, 2025

Uh oh!

robwalch Aug 29, 2025

Uh oh!

ShubhamSharma2311 Aug 30, 2025

Uh oh!

robwalch Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	export function parsePlayReadyWRM(keyBytes: Uint8Array<ArrayBuffer>) {
	const keyBytesUtf16 = new Uint16Array(
	keyBytes.buffer,
	keyBytes.byteOffset,
	keyBytes.byteLength / 2,
	);
	const keyByteStr = String.fromCharCode.apply(null, Array.from(keyBytesUtf16));

	// Parse Playready WRMHeader XML
	const xmlKeyBytes = keyByteStr.substring(
	keyByteStr.indexOf('<'),
	keyByteStr.length,
	);
	const parser = new DOMParser();
	const xmlDoc = parser.parseFromString(xmlKeyBytes, 'text/xml');
	const keyData = xmlDoc.getElementsByTagName('KID')[0];
	if (keyData) {
	const keyId = keyData.childNodes[0]
	? keyData.childNodes[0].nodeValue
	: keyData.getAttribute('VALUE');
	if (keyId) {
	const keyIdArray = base64Decode(keyId).subarray(0, 16);
	// KID value in PRO is a base64-encoded little endian GUID interpretation of UUID
	// KID value in ‘tenc’ is a big endian UUID GUID interpretation of UUID
	changeEndianness(keyIdArray);

Fix PlayReady key endianness #7510

Fix PlayReady key endianness #7510

Uh oh!

Conversation

ShubhamSharma2311 commented Aug 28, 2025

Uh oh!

robwalch commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShubhamSharma2311 commented Aug 29, 2025

Uh oh!

hongfeih-es Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robwalch Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

robwalch Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

ShubhamSharma2311 Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

robwalch Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

robwalch commented Aug 29, 2025 •

edited

Loading

hongfeih-es Aug 29, 2025 •

edited

Loading