Error handling for PlayReady key with no status change #7527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
robwalch
force-pushed
the
bugfix/playready-key-timeout-error-handling-patch
branch
from
b711714 to
331a02e
Compare
This was
linked to
issues
Sep 5, 2025
5 tasks
5 tasks
Log append queing
robwalch
deleted the
bugfix/playready-key-timeout-error-handling-patch
branch
robwalch
added a commit
that referenced
this pull request
Sep 6, 2025
* Error handling for PlayReady key with no status change #7508 * Remove hanging promises (except for renewal) * Log append queing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Are there any points in the code the reviewer needs to double check?
Currently this will prevent switching up to levels with bad keys. HLS.js will also switch down after starting on a level with a bad key, but a reset (
hls.recoverMediaError()or detach/attach media element) may be required to restore playback.This PR contains some of the changes from #7517 without the changes that group keys into sessions. This is to reduce the complexity of changes going into the next patch, and to simplify key error handling as sessions to keys are still one-to-one.
Resolves issues:
#7519
CC
requireKeySystemAccessOnStartwith live #7383Checklist