Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3a4d0bf to
982de02
Compare
📦 Bundle Size Report
Total: 23.67 kB · +416 B · +1.7% Entry BreakdownSubpath sizes are the additional bytes on top of the root entry point, measured by bundling root + subpath together and subtracting the root-only size.
|
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.32 kB | 1.32 kB | 0 B | 0% | ✅ |
./dom |
2.68 kB | 2.68 kB | 0 B | 0% | ✅ |
| total | 4.00 kB | 4.00 kB | 0 B | 0% |
@videojs/element
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
817 B | 817 B | 0 B | 0% | ✅ |
./context |
823 B | 823 B | 0 B | 0% | ✅ |
| total | 1.60 kB | 1.60 kB | 0 B | 0% |
@videojs/react
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
6.53 kB | 6.45 kB | -79 B | -1.2% | 🔽 |
./audio |
— | 243 B | — | 🆕 | |
./background |
— | 36 B | — | 🆕 | |
./video |
— | 216 B | — | 🆕 | |
| total | 6.53 kB | 6.94 kB | +416 B | +6.2% |
@videojs/store
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
. |
1.29 kB | 1.29 kB | 0 B | 0% | ✅ |
./html |
394 B | 394 B | 0 B | 0% | ✅ |
./react |
190 B | 190 B | 0 B | 0% | ✅ |
| total | 1.86 kB | 1.86 kB | 0 B | 0% |
@videojs/utils
| Entry | Base | PR | Diff | % | |
|---|---|---|---|---|---|
./array |
104 B | 104 B | 0 B | 0% | ✅ |
./dom |
553 B | 553 B | 0 B | 0% | ✅ |
./events |
227 B | 227 B | 0 B | 0% | ✅ |
./function |
181 B | 181 B | 0 B | 0% | ✅ |
./object |
119 B | 119 B | 0 B | 0% | ✅ |
./predicate |
265 B | 265 B | 0 B | 0% | ✅ |
./time |
465 B | 465 B | 0 B | 0% | ✅ |
| total | 1.87 kB | 1.87 kB | 0 B | 0% |
ℹ️ How to interpret
Sizes are minified + brotli, measured with esbuild.
Package totals are computed as root size + marginal subpath costs.
Subpath marginal cost = (root + subpath bundled together) − root alone.
| Icon | Meaning |
|---|---|
| ✅ | No change |
| 🔺 | Increased ≤ 10% |
| 🔴 | Increased > 10% |
| 🔽 | Decreased |
| 🆕 | New (no baseline) |
Run pnpm size locally to check current sizes.
982de02 to
2a1b522
Compare
There was a problem hiding this comment.
Are we planning on having vanilla CSS files ready first? I'd assume Tailwind and hand written vanilla only as stop gap if compiler isn't ready. If it is Tailwind first then we can remove these probably and get that side setup.
Thoughts?
There was a problem hiding this comment.
I'm assuming we'd use hand-rolled vanilla CSS files first and then the Tailwind compiled versions come later. Probably a good subject to discuss.
There was a problem hiding this comment.
I assume the docs are going to have to at least use the hand-rolled vanilla CSS unless we want to get back into the vjs prefix stuff we had in tech preview.
There was a problem hiding this comment.
I guess it depends if we're supporting eject or not in Beta, I don't see it in Sarah's doc so maybe not.
If that's right then starting vanilla makes sense :)
There was a problem hiding this comment.
Starting vanilla is pretty cool actually because it gives us a real reference to test the compiler against.
There was a problem hiding this comment.
Yeah, I think @cpillsbury was keen to have an "expected CSS" to compare against so that would be the aim 👍🏼
2a1b522 to
88a3a2d
Compare
CSS watch/copy changesReplaced the
Tested: CSS changes in |
Just for React only at this point. If we're happy with the direction, I'll roll it out to the html side too.
dist(watch and build).Imports would look like this: