Prevent set disabled metadata TextTrack when create snapshot#545
Open
nonth wants to merge 1 commit intovideojs:mainfrom
Open
Prevent set disabled metadata TextTrack when create snapshot#545nonth wants to merge 1 commit intovideojs:mainfrom
nonth wants to merge 1 commit intovideojs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior and problem
Before play ads that trigger by Cue Text Tracks the plugin create a player's snapshot in this process plugin store TextTrack in suppressedTracks array then set track mode to disabled to prevent TextTrack (subtitles?) to display on player when ads is playing after ads end the plugin restore player's snapshot and set TextTrack's mode back to original (before play ads)
After set TextTrack's mode back to original the browser see that TextTrack change from inactive to active it will trigger a
cuechangeeventThe integration received
cuechangeevent then it try to play ads and repeat the whole snapshot process again forever you can see this behavior in example link belowexample
Solution
In this PR will not set metadata TextTrack mode to disabled since metadata TextTrack is not visible on player and it will prevent browser to forever trigger
cuechangeeventit's fixed the problem that I've mention above
example