fix: improve legacy fairplay workflow detection#235
Merged
Conversation
misteroneill
approved these changes
Jul 22, 2025
gkatsev
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #234 I was made aware of a use case where a user's Fairplay key system was provided as
com.apple.fps.1_0but their custom VJS / contrib-eme setup did not callinitLegacyFairplay. The were able to get this working by adding!window.MediaKeysto my modified exit conditional inhandleEncryptedEvent.i.e.:
if (options.keySystems[LEGACY_FAIRPLAY_KEY_SYSTEM] && window.WebKitMediaKeys && !window.MediaKeys)On modern Safari, this will evaluate to false (as both
WebKitMediaKeysandMediaKeysare present), so in their case,handleEncryptedEventwould continue with the standard EME workflow.This got me thinking that we really should be considering whether the legacy Fairplay workflow is actually in use when deciding whether or not to exit
handleEncryptedEvent, as the key system alone is not definite.So the changes here make that signal more definite by adding a flag in
initLegacyFairplaythathandleEncryptedEventcan use to know for sure that it should exit.