Skip to content

Add worker/server target to react build script #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nols1000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add worker/server target to react build script #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions packages/react/rollup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ const NPM_EXTERNAL_PACKAGES = [
/^@floating-ui/,
/^remotion/,
],
NPM_BUNDLES = [defineNPMBundle({ dev: true }), defineNPMBundle({ dev: false })],
NPM_BUNDLES = [
defineNPMBundle({ type: 'server' }),
defineNPMBundle({ type: 'dev' }),
defineNPMBundle({ type: 'prod' }),
],
TYPES_BUNDLES = defineTypesBundle();

if (!MODE_TYPES) {
Expand Down Expand Up @@ -115,11 +119,12 @@ function resolveGlobalTypes(): Plugin {
}

interface NPMBundleOptions {
dev?: boolean;
type: 'dev' | 'prod' | 'server';
}

function defineNPMBundle({ dev }: NPMBundleOptions): RollupOptions {
const alias = dev ? 'dev' : 'prod';
function defineNPMBundle({ type }: NPMBundleOptions): RollupOptions {
const isProd = type === 'prod',
isServer = type === 'server';

let input = {
vidstack: 'src/index.ts',
Expand All @@ -131,21 +136,21 @@ function defineNPMBundle({ dev }: NPMBundleOptions): RollupOptions {
'player/vidstack-default-icons': 'src/components/layouts/default/icons.tsx',
};

if (!dev) {
if (isProd) {
input['vidstack-icons'] = 'src/icons.ts';
}

return {
input,
treeshake: true,
preserveEntrySignatures: 'allow-extension',
maxParallelFileOps: !dev ? 1 : 20,
maxParallelFileOps: isProd ? 1 : 20,
external: NPM_EXTERNAL_PACKAGES,
output: {
format: 'esm',
compact: false,
minifyInternalExports: false,
dir: `dist-npm/${alias}`,
dir: `dist-npm/${type}`,
chunkFileNames: `chunks/vidstack-[hash].js`,
manualChunks(id) {
if (id.includes('node_modules')) return 'vidstack-deps';
Expand All @@ -154,19 +159,23 @@ function defineNPMBundle({ dev }: NPMBundleOptions): RollupOptions {
plugins: [
env(),
nodeResolve({
exportConditions: dev
? ['development', 'production', 'default']
: ['production', 'default'],
exportConditions: isServer
? ['node', 'default', 'development']
: isProd
? ['production', 'default']
: ['development', 'production', 'default'],
}),
decorators(),
typescript({
loader: 'tsx',
platform: isServer ? 'node' : 'browser',
define: {
__DEV__: dev ? 'true' : 'false',
__DEV__: !isProd && !isServer ? 'true' : 'false',
__SERVER__: isServer ? 'true' : 'false',
},
}),
rscDirectives(),
!dev && copyAssets(),
isProd && copyAssets(),
],
};
}
Expand Down Expand Up @@ -224,7 +233,7 @@ function copyAssets(): Plugin {
return {
name: 'copy-assets',
async buildEnd() {
await copyPkgFiles();
copyPkgFiles();
await copyStyles();
await copyTailwind();
await buildDefaultTheme();
Expand Down