Exposed accessToken to JS #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed naming for credentials
Removed junky code
viestat
reviewed
Feb 3, 2018
| if(!error){ | ||
| SpotifyModule.startAuthenticationFlow((error, str) => { | ||
| if(!error){ | ||
| console.log("New Access Token = "+str); |
Owner
There was a problem hiding this comment.
I would change this to template literals:
`New Access Token ${str}`
viestat
reviewed
Feb 3, 2018
| } | ||
| }); | ||
| } else { | ||
| console.log("Cached Access Token = "+accessToken); |
viestat
reviewed
Feb 3, 2018
| block(@[notification.userInfo[@"error"]]); | ||
| } else { | ||
| block(@[[NSNull null]]); | ||
| block(@[notification.userInfo[@"error"], @"not wow"]); |
Owner
There was a problem hiding this comment.
Maybe a more descriptive message.
viestat
approved these changes
Feb 3, 2018
Owner
viestat
left a comment
viestat
left a comment
There was a problem hiding this comment.
Please note my comments about super small changes, but it looks good to me in general.
Would be also nice if README was also updated in the same PR but I can do that later.
Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the accessToken to the React Native code for simultaneous use of Spotify Web Api.
Fixes #19