This repository was archived by the owner on Sep 15, 2023. It is now read-only.
Added fs-extra as a direct dependency of Blendid#553
Open
maoueh wants to merge 1 commit intovigetlabs:masterfrom
Open
Added fs-extra as a direct dependency of Blendid#553maoueh wants to merge 1 commit intovigetlabs:masterfrom
maoueh wants to merge 1 commit intovigetlabs:masterfrom
Conversation
The fs-extra is required directly by Blendid in file `gulpfile.js/tasks/replace-files.js`. However, this dependency was expected to be present transitively via `browser-sync`. Since it's a direct dependency of Blendid, it should be listed as such in the `package.json`. By not being present, it was causing us problem when using Yarn workspaces where `fs-extra` was not resolvable correctly ( because it was in different `node_modules` folder). Used version `fs-extra@3.0.1` to remain the same as `browser-sync#fs-extra`.
maoueh
force-pushed
the
fix/fs-extra-dependency-missing
branch
from
1ab86bf to
56a83d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fs-extra is required directly by Blendid in file
gulpfile.js/tasks/replace-files.js. However, this dependency was expected to be present transitively viabrowser-sync.Since it's a direct dependency of Blendid, it should be listed as such in the
package.json. By not being present, it was causing us problem when using Yarn workspaces wherefs-extrawas not resolvable correctly (because it was in differentnode_modulesfolder).Used version
fs-extra@3.0.1to remain the same asbrowser-sync#fs-extra.