ChartDataset.Data generics #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to shadow it (cherry picked from commit 35383ee)
|
@mhspelt Thank you for the PR. Can you share at least one scenario for an inheritance issue, just for my understanding? |
Hi @gvreddy04, here's a very simple example of a code snippet that shows two problems: https://dotnetfiddle.net/1tO4pg
Both of these behaviors are, to me as a client of the library, unexpected and are IMHO elegantly fixed by this PR. [edit]I wrote "dumps 0" in the example, should have been "dumps null"[/edit] |
gvreddy04
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest version, the base ChartDataset.Data field was changed to
object, then derived classes declared it asnew List<double?>?. I understand this change was made to support the ScatterChart, but it was giving me problems with inheritance, so I changed it to use generics and avoid the shadowing.