Bring back ember-source to peerDependencies for dependencySatisfies macro#100
Open
SergeAstapov wants to merge 1 commit intovillander:masterfrom
Open
Bring back ember-source to peerDependencies for dependencySatisfies macro#100SergeAstapov wants to merge 1 commit intovillander:masterfrom
SergeAstapov wants to merge 1 commit intovillander:masterfrom
Conversation
SergeAstapov
force-pushed
the
ember-source-peers
branch
from
7684004 to
4b7e4a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/villander/ember-engines-router-service/blob/v0.7.0/ember-engines-router-service/src/services/engine-router-service.js#L73 we use
which fails when app uses pnpm because
dependencySatisfiescan't findember-sourcefrom withinember-engines-router-serviceand we fall into "else" switch.this reverts change made in https://github.com/villander/ember-engines-router-service/pull/99/changes#diff-66510d62c3961a023b73422354c76f9dd7160d604d492f8b4030a28a29e818c3L73