feat: switch to pnpm & Remove ember-source as a peer dependency#99
feat: switch to pnpm & Remove ember-source as a peer dependency#99villander merged 2 commits intovillander:masterfrom
pnpm & Remove ember-source as a peer dependency#99Conversation
aklkv
force-pushed
the
feat/pnpm
branch
3 times, most recently
from
4f7d974 to
e3cb6d6
Compare
villander
left a comment
villander
left a comment
There was a problem hiding this comment.
Thank you for the great work! There are some questions and minor changes before we move forward.
| "@types/ember__routing": "^4.0.22", | ||
| "babel-plugin-ember-template-compilation": "^2.2.5", | ||
| "concurrently": "^8.2.2", | ||
| "ember-source": "^6.4.0", |
There was a problem hiding this comment.
Isn't it necessary to keep covering old Ember versions as we were doing before?
There was a problem hiding this comment.
ember-try does this for us and in this case we are only using ember-source for types only
| "@release-it-plugins/workspaces": "^4.2.0", | ||
| "release-it": "^17.5.0" | ||
| }, | ||
| "packageManager": "pnpm@10.12.1+sha512.f0dda8580f0ee9481c5c79a1d927b9164f2c478e90992ad268bbb2465a736984391d6333d2c327913578b2804af33474ca554ba29c04a8b13060a717675ae3ac", |
There was a problem hiding this comment.
Why is it needed? It does not seem to be the right thing to do with this long version. Why can't we simply use 10.12.1?
https://stackoverflow.com/questions/71747609/how-to-specify-packagemanager-in-package-json
There was a problem hiding this comment.
corepack adds a sha for integrity check
| @action goToChineseVersion() { | ||
| this.transitionTo({ queryParams: { lang: 'Chinese' } }); | ||
| } | ||
|
|
||
| @action transitionToHome() { | ||
| this.transitionToExternal('home').then(() => { | ||
| var postController = this.controllerFor(this.routeName); | ||
| postController.set('transitionedToExternal', true); | ||
| }); | ||
| } | ||
|
|
||
| @action replaceWithHome() { | ||
| this.replaceWithExternal('home').then(() => { | ||
| var postController = this.controllerFor(this.routeName); | ||
| postController.set('replacedWithExternal', true); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Why are we moving it from route to controller?
There was a problem hiding this comment.
route actions are deprecated
| @@ -10,12 +10,3 @@ npm-debug.log* | |||
| yarn-error.log | |||
There was a problem hiding this comment.
could you please remove it as well?
There was a problem hiding this comment.
that is part of blueprint so I didn't remove it as it was not showing in the diff
villander
changed the title
pnpmpnpm & Remove ember-source as a peer dependency
2 participants
pnpmember-engines& add locallink-to-externalcomponents as it's not exposed anymore{{action}}helpers