Update develop.{txt,jax} #1833
Closed
Update develop.{txt,jax} #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
forkリポジトリに間違ってスタイル変更の help.jax をcommit&pushしちゃって後から revert したけど、それ以降のPRに変なcommit付いてしまうので、help.jax のcommit&revert の分を rebase でdropしたんですけど、、、(長い) |
Member
Author
|
このPRを先にmergeしちゃうと、他のPR変なことになる？ |
Member
これブランチは master ですかね？ 多分 master については h-east@7a2e8a1 からこれも含めた先のコミットを落とすと、以降の PR でも「それ以降のPRに変なcommit付いてしまう」というのが良い感じになおるんじゃないかと思います。
ちょっと git とか GitHub とかの細かい挙動がよくわかってないのでわかりません...が、この PR の差分表示タブの内容を見る感じ無事そうな気はしますね。 |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.