Skip to content

Fix Data.Dict.max_by after Vim v9.1.1684#833

Merged
thinca merged 1 commit intomasterfrom
fix-Data.Dict.max_by-after-v9.1.1684
Sep 19, 2025
Merged

Fix Data.Dict.max_by after Vim v9.1.1684#833
thinca merged 1 commit intomasterfrom
fix-Data.Dict.max_by-after-v9.1.1684

Conversation

@thinca
Copy link
Member

@thinca thinca commented Sep 13, 2025

cause: vim/vim@3b3b936 Convert values pass to max() from String to Number.

Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

従来動作を維持する方向ですね、LGTM

@tsuyoshicho
Copy link
Contributor

@thinca
#829
すみません、上で venv の対応はできてるはずなので、リベース or merge master していただけますか?

cause: vim/vim@3b3b936
Convert values pass to max() from String to Number.
@thinca thinca force-pushed the fix-Data.Dict.max_by-after-v9.1.1684 branch from d7406c6 to fe1feb8 Compare September 19, 2025 11:16
@thinca
Copy link
Member Author

thinca commented Sep 19, 2025

すいません遅くなりましたが rebase しました。

@thinca
Copy link
Member Author

thinca commented Sep 19, 2025

CI 通ったし Approve ももらっているのでマージしちゃいます!

@thinca thinca merged commit 42f4dc8 into master Sep 19, 2025
33 of 34 checks passed
@thinca thinca deleted the fix-Data.Dict.max_by-after-v9.1.1684 branch September 19, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants