Skip to content

Timing object updates#941

Merged
arturparkhisenko merged 9 commits intomasterfrom
timing-object-updates
Jul 14, 2025
Merged

Timing object updates#941
arturparkhisenko merged 9 commits intomasterfrom
timing-object-updates

Conversation

@salmoro
Copy link
Contributor

@salmoro salmoro commented Jun 29, 2023

  1. Make updateTimingObject of TimingSrcConnector to be more atomic to increase the accuracy of the player state snapshot captured when updating the TimingObject.
  2. Use Typescript types for TimingObject from https://github.com/chrisguttandin/timing-object instead of declaring in our codebase so that if one uses both packages they're less likely to run into type-related issues.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.92%. Comparing base (f6d6951) to head (c29c8c3).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   71.95%   71.92%   -0.03%     
==========================================
  Files           7        7              
  Lines         599      602       +3     
==========================================
+ Hits          431      433       +2     
- Misses        168      169       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salmoro salmoro requested a review from rkrishnan8594 July 6, 2023 20:29
@arturparkhisenko arturparkhisenko self-assigned this Jul 7, 2025
@arturparkhisenko arturparkhisenko requested a review from a team July 10, 2025 18:32
@arturparkhisenko arturparkhisenko merged commit dd40575 into master Jul 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants