Skip to content

Distinguish intentional JIT disable from unexpected failure in status message #11681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alies-dev wants to merge 1 commit into
base: 6.x
Choose a base branch
from
+13 −4
Open

Distinguish intentional JIT disable from unexpected failure in status message #11681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Psalm/Internal/Cli/Psalm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,10 +1002,19 @@ private static function restart(
. 'JIT acceleration: ON'
. PHP_EOL . PHP_EOL);
} else {
$progress->write(PHP_EOL
. 'JIT acceleration: OFF (an error occurred while enabling JIT)' . PHP_EOL
. 'Please report this to https://github.com/vimeo/psalm with your OS and PHP configuration!'
. PHP_EOL . PHP_EOL);
$jitSetting = ini_get('opcache.jit');
if ($jitSetting === false || $jitSetting === '' || $jitSetting === '0'
|| in_array(strtolower($jitSetting), ['off', 'disable', 'disabled'], true)
) {
$progress->write(PHP_EOL
. 'JIT acceleration: OFF (opcache.jit is disabled)'
. PHP_EOL . PHP_EOL);
} else {
$progress->write(PHP_EOL
. 'JIT acceleration: OFF (an error occurred while enabling JIT)' . PHP_EOL
. 'Please report this to https://github.com/vimeo/psalm with your OS and PHP configuration!'
. PHP_EOL . PHP_EOL);
}
}
} else {
$progress->write(PHP_EOL
Expand Down
Loading