Draft
Conversation
Same issue as fixed in TypeParser in vimeo#11704
Preparation to fix vimeo#11705 and prevent issues in the future
Fix vimeo#11705 Remove unnecessary check for own functions
Fix github.com/vimeo/issues/11706
Fix path handling on Windows Quiet download progress
Create separate temp files for each version to prevent race conditions
* Speed up building of docker by always running 2 versions at the same time, instead of in batches of 2 * Remove hardcoded PHP versions for docker and stubs scripts and dynamically load the supported PHP versions from available dockerfiles * Add option to build docker images locally without pushing to Github container registry * Add option to rebuild only specified docker image, only missing docker images or all docker images * avoid downloading the same container for autogen callmap and final callmap * use local container if remote does not exist and build container locally if not available locally yet for a version * install composer if vendor does not exist to allow quick, standalone recreation of stubs in CI or other machine * fix callmap could not be generated due to wrong working directory
kkmuffme
force-pushed
the
fix-invalid-callmaps
branch
from
2a88b28 to
eb9e813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also fixes the callmap/stubs generation, since it wasn't working at all on Windows, for PHP 8.5 on any platform, for any version on any platform, since it had a fatal due to wrong path.
Also makes it easier to use by automatically installing composer/vendor (e.g. to allow updating/rerunning callmap generating in CI)