feat: multiple files as args in purge/recover#5
Merged
Conversation
vimlinuz
commented
Aug 31, 2025
Owner
Author
vimlinuz
left a comment
vimlinuz
left a comment
There was a problem hiding this comment.
some performance improvement can be done there
src/main.rs
Outdated
| if let Err(e) = recover_from_trash(name) { | ||
| eprintln!("Error recovering from trash: {e}"); | ||
| let contents_to_recover = args.get_recover_name(); | ||
| for content in contents_to_recover { |
src/main.rs
Outdated
| if let Err(e) = purge(filename) { | ||
| eprintln!("Error removing the content from the bin: {e}") | ||
| let files_to_purge = args.get_purge_name(); | ||
| for file in files_to_purge { |
Owner
Author
There was a problem hiding this comment.
Calling os_limited multiple time is performance heavy
remove that function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user can now pass multiple files or content to the command that can recover all the passed content as well as the content that are to be deleted completely from the trash