Added an option to only select required fields#36
Open
varnitsingh wants to merge 1 commit intovinay20045:masterfrom
Open
Added an option to only select required fields#36varnitsingh wants to merge 1 commit intovinay20045:masterfrom
varnitsingh wants to merge 1 commit intovinay20045:masterfrom
Conversation
Author
|
resolves #35 |
Owner
|
Hi @varnitsingh, Thanks for submitting this PR! This not only resolves #35 but is definitely going to be a useful feature. However, I think this needs a bit more discussion around the implementation... Some initial thoughts/questions I have are...
Let me know what you think. |
vinay20045
reviewed
Oct 2, 2020
| if len(sys.argv) > 4: | ||
| for i in range(4,len(sys.argv)): | ||
| acceptable_keys.append(sys.argv[i]) | ||
| print('Only copying from: ',end='') |
Owner
There was a problem hiding this comment.
This line is throwing syntax error.
Author
There was a problem hiding this comment.
Try removing end=''. See if that works. There is a issue sometimes with the python linter.
Author
|
Answering your questions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added an option to only add selected fields to the csv files by specifying fields after the path arguments
python json_to_csv.py <node> <json_in_file_path> <csv_out_file_path> <field1> <field2>