Fix past end array access on unsigned char builds #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There are some platforms where `char` is implemented as `unsigned char` such as arm architectures. In this systems, the existing code to access the `ParseFlagMap` and `WhitespaceMap` arrays will access elements past the end of the arrays. - This PR fixes the bug by making the offset to convert the `char` into an array index dependent on how `char` is implemented. - Modifications on single headers were manually introduced as the command: `cmake --build build/ --target=generate_single_header` Introduces way more changes than the introduced ones.
Owner
|
Thank you for your thoughtful & robust PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charis implemented asunsigned charsuch as arm architectures. In these systems, the existing code to access theParseFlagMapandWhitespaceMaparrays will access elements past the end of the arrays.charinto an array index dependent on howcharis implemented.cmake --build build/ --target=generate_single_headerIntroduces way more changes than the introduced ones.Fix: #222
This PR provides an alternative approach that the solution presented in #247