Skip to content

Commit 4301030

Browse files
ShahanaFarooquirustyrussell
authored andcommitted
plugins/clnrest: Updated clnrest install command in Docker images and CI
We do not need explicit clnrest dependencies installation for clnrest because `poetry install` will also install clnrest libraries.
1 parent 6a75625 commit 4301030

File tree

4 files changed

+0
-5
lines changed

4 files changed

+0
-5
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ jobs:
5454
# Export and then use pip to install into the current env
5555
poetry export -o /tmp/requirements.txt --without-hashes --with dev
5656
pip install -r /tmp/requirements.txt
57-
# Make sure we have clnrest requirements, for check-manpages
58-
pip install -r plugins/clnrest/requirements.txt
5957
# We're going to check BOLT quotes, so get the latest version
6058
git clone https://github.com/lightning/bolts.git ../${BOLTDIR}
6159
- name: Configure

contrib/docker/scripts/build.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ pip3 install --upgrade pip
2323
pip3 install --user poetry
2424
poetry export --dev --without-hashes -o requirements.txt
2525
pip3 install -r requirements.txt
26-
pip3 install -r plugins/clnrest/requirements.txt
2726

2827
git clone https://github.com/lightning/bolts.git ../bolts
2928
git submodule update --init --recursive

contrib/reprobuild/Dockerfile.focal

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ WORKDIR /build
6060

6161
CMD poetry export -o requirements.txt --without-hashes \
6262
&& pip install -r requirements.txt \
63-
&& pip install -r plugins/clnrest/requirements.txt \
6463
&& mkdir -p /repro \
6564
&& cd /repro \
6665
&& unzip /build/release/*.zip \

contrib/reprobuild/Dockerfile.jammy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ WORKDIR /build
6161

6262
CMD poetry export -o requirements.txt --without-hashes \
6363
&& pip install -r requirements.txt \
64-
&& pip install -r plugins/clnrest/requirements.txt \
6564
&& mkdir -p /repro \
6665
&& cd /repro \
6766
&& unzip /build/release/*.zip \

0 commit comments

Comments
 (0)