README.md: fix mismatch between repo and app name in install instruct…#1
Open
sysread wants to merge 1 commit intovinibrsl:mainfrom
Open
README.md: fix mismatch between repo and app name in install instruct…#1sysread wants to merge 1 commit intovinibrsl:mainfrom
sysread wants to merge 1 commit intovinibrsl:mainfrom
Conversation
…ions The app is generated as `bina.app`, but the repo name is `mix_bina`, which causes a compile error. The `git:` argument to `deps` allows us to specify the repo URI while ensuring that the app name matches the one specified in bina's mix.exs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change to the install instructions is required to use this module in another elixir project.
mix_binaspecifiedbinaas the name of the app in mix.exs.That causes the module to be compiled as
bina.app, rather thanmix_bina.app, causing a mismatch if you add it as a dep using the namemix_bina. Instead, we can specify the package's home using thegitargument todeps, allowing us to name the appbinawithout losing our ability to find the source.