updated aws4 version and fixed the Authentication issue #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aravindh-Raju
approved these changes
Mar 29, 2024
Member
Aravindh-Raju
left a comment
Aravindh-Raju
left a comment
There was a problem hiding this comment.
Tested it out locally. Able to perform all the actions now. LGTM!
| 'Content-Type': 'application/json' | ||
| }, | ||
| body: opts.body ? JSON.stringify(opts.body) : '' | ||
| body: JSON.stringify(opts.body) |
Member
There was a problem hiding this comment.
Will we get an error when opts.body is empty as the condition is removed?
Member
Author
There was a problem hiding this comment.
Yeh . If the body is null or undefined, we will get an error.
|
|
||
| echo "Removing VinylDNS API if exists.." | ||
| if docker ps | grep -q "vinyldns-js-api"; then | ||
| if docker ps -a| grep -q "vinyldns-js-api"; then |
Member
There was a problem hiding this comment.
I think the -a is added for testing? If so, we can remove them.
Member
Author
There was a problem hiding this comment.
this done purposely to pull all running docker container and stop which has the name vinyldns-js-api
Jay07GIT
added
kind/maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR.
aws4versionaxiosdependency