Skip to content

updated aws4 version and fixed the Authentication issue #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jay07GIT wants to merge 7 commits into
base: master
Choose a base branch
from
Open

updated aws4 version and fixed the Authentication issue #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4df22a0
updated aws4 version and fixed the Authentication issue
Jay07GIT Mar 5, 2024
5c6d2d0
update package-json
Jay07GIT Mar 5, 2024
f3cd6e3
update
Jay07GIT Mar 5, 2024
4e57d7c
update
Jay07GIT Mar 6, 2024
d19a586
update
Jay07GIT Mar 13, 2024
79b0fc0
resolved failed tests
Jay07GIT Mar 28, 2024
a56039d
update
Jay07GIT Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/run-integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -e
VINYLDNS_VERSION="0.10.4"

echo "Removing VinylDNS API if exists.."
if docker ps | grep -q "vinyldns-js-api"; then
if docker ps -a| grep -q "vinyldns-js-api"; then
Copy link
Member

@Aravindh-Raju Aravindh-Raju Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the -a is added for testing? If so, we can remove them.

Copy link
Member Author

@Jay07GIT Jay07GIT Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this done purposely to pull all running docker container and stop which has the name vinyldns-js-api

docker kill vinyldns-js-api &> /dev/null || true
docker rm vinyldns-js-api &> /dev/null || true
echo "Removed VinylDNS API"
Expand Down
Loading