Fix doXover on the new semantics#395
Merged
jcp19 merged 10 commits intodrop_fractions_functionsfrom Feb 3, 2025
Merged
Conversation
jcp19
added a commit
that referenced
this pull request
Feb 3, 2025
) * test * Apply suggestions from code review * Update pkg/slayers/path/epic/epic_spec.gobra * Update pkg/slayers/path/epic/epic_spec.gobra * drop unnecessary formalization of waitgroups * tiny change * drop access predicates * stabilize verification conditions that now fail * fix yet one more proof obligation; extract code into additional theorem * yet another proof obligation fixed * refactor widen lemma for HopField to reuse a previous proof * fix bad triggers generated by Gobra * Refactor parts of scion_spec.gobra for proof stability (#389) * backup * cleanup * Update pkg/slayers/scion.go * Update pkg/slayers/scion_spec.gobra * backup * backup * backup * backup * fix proof obligation in CurrSegEquality * drop Uncallable * fix outstanding proof obligations * drop unnecessary function * backup * restore old spec * add gobra action cfg * Update pkg/slayers/path/path_spec.gobra * Fix `doXover` on the new semantics (#395) * start * identify problematic postconditions * drop one assumption * drop comments * fix proof of new postconditions of XoverLemma * small simplifications * drop yet another assumption * drop last assumption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #387. Turns out that the proof of
doXoveris rightly rejected in the new semantics, and the reason it was accepted in the first place was due to an unsoundness in silicon (viperproject/silicon#894). Despite the old proof being wrongly accepted, the specs are true, and thus, this unsoundness had a very restricted effect in the project.