GitHub Continuous Integration #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and prints java version
Felalolf
approved these changes
Sep 30, 2020
Felalolf
left a comment
Felalolf
left a comment
There was a problem hiding this comment.
As stated before, my knowledge about type scipt is minimal. I tried to give constructive feedback.
Aurel300
reviewed
Sep 30, 2020
Aurel300
reviewed
Sep 30, 2020
Aurel300
reviewed
Sep 30, 2020
Member
Author
|
@Aurel300 Thanks a lot for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Gitlab's CI config, adds a similar one for GitHub workflows. The main difference is that the tests are not only executed on Ubuntu but also on macOS and Windows.
This PR includes some code refactoring because I was hunting the reason why the integration tests did not seem to terminate on macOS.
Notice that the
locate-java-homepackage has (temporarily) been replaced by a fork of mine, because the CI on Windows did not find the Java installation. There's an open PR to feed the required changes back to the mainlocate-java-homepackage.