-
Notifications
You must be signed in to change notification settings - Fork 37
Fix overflow checks #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jcp19
wants to merge
34
commits into
master
Choose a base branch
from
fix-overflow-checks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix overflow checks #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add names to axioms; reorganize codebase
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes overflow checking in Gobra and adds support for a new ghost type
integer, with unlimited precision, which is useful in specifications and ghost code, where we don't need to deal with operations on limited precision integers.This PR touches fundamental parts of the encoding:
Ints. This transformation is now required to make sure that the generated operations on integers are well-typed. This change lays the groundwork for proper encoding of bitwise operations in the future, as it is clear now what bitvector types and operations should be selected from the integer type when performing the encoding.This is an experimental PR, currently under improvement and under-testing in VerifiedSCION. To make this fully pratical, we need to add support for a way to sidestep overflow checks when overflows are intentional.
TODO: Merge the changes gradually in Gobra. Possible steps:
integerfrom this PRThere are two additions that I think would be very useful:
+as the following total function: